Re: Bug #925: typing error in src/backend/libpq/be-secure.c

Actually, the docs say SSL_read/write can error needing READ or WRITE:

http://www.openssl.org/docs/ssl/SSL_read.html#

The SSL_write docs are the same. I have applied the following patch to
handle both new cases. Does this help the SSL test program you have?

---------------------------------------------------------------------------

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Yep, typo. Patched to CVS current and backpatched to 7.3.X.
>
> I think this fix is exactly backward. Why would SSL_write need to
> return ERROR_WANT_WRITE? It couldn't. The correct fix is that
> SSL_write might return ERROR_WANT_READ, for which reading would be
> the right response.
>
> BTW the real problem, both here and elsewhere in this file, is the
> lack of a "default: elog-out" case in the switch statements. This
> code will simply break if any unexpected case occurs.
>
> regards, tom lane
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073