From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> |
Cc: | Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Add CLUSTER ON to pg_dumps |
Date: | 2003-03-22 03:46:34 |
Message-ID: | 200303220346.h2M3kYP18922@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
I will make this adjustment to the patch.
---------------------------------------------------------------------------
Alvaro Herrera wrote:
> On Fri, Mar 21, 2003 at 12:25:17PM +0800, Christopher Kings-Lynne wrote:
>
> > + /*
> > + * If the index is clustered, we need to issue a CLUSTER command
> > + * since that is the only way of setting indisclustered.
> > + */
> > + if (indisclustered) {
> > + appendPQExpBuffer(q, "\nALTER TABLE %s CLUSTER",
> > + fmtId(tbinfo->relname));
> > + appendPQExpBuffer(q, " ON %s;\n",
> > + fmtId(indexrelname));
> > + }
>
> You forgot to update the comments...
>
> --
> Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
> "Escucha y olvidar?s; ve y recordar?s; haz y entender?s" (Confucio)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Joe Conway | 2003-03-22 23:56:13 | IS OF |
Previous Message | Bruce Momjian | 2003-03-22 03:45:49 | Re: Add CLUSTER ON to pg_dumps |