Re: InvalidOid & C++

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Jeroen T(dot) Vermeulen" <jtv(at)xs4all(dot)nl>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: InvalidOid & C++
Date: 2003-03-18 01:33:42
Message-ID: 200303180133.h2I1XgV09718@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


How widespread is Oid(0) in C++? I have never seen anything like that.
It looks like a function call!

---------------------------------------------------------------------------

Jeroen T. Vermeulen wrote:
> Compiling anything that uses InvalidOid under g++ yields a warning about
> the expression using an "old-style cast." Therefore, would it be okay to
> patch postgres_ext.h as follows:
>
>
> *** src/include/postgres_ext.h 2003-02-22 16:24:28.000000000 +0100
> --- ../postgres_ext.h 2003-03-06 21:44:11.000000000 +0100
> ***************
> *** 28,34 ****
> --- 28,38 ----
> */
> typedef unsigned int Oid;
>
> + #ifdef __cplusplus
> + #define InvalidOid (Oid(0))
> + #else
> #define InvalidOid ((Oid) 0)
> + #endif
>
> #define OID_MAX UINT_MAX
> /* you will need to include <limits.h> to use the above #define */
>
>
> Jeroen
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-03-18 01:34:44 Re: stats_command_string default?
Previous Message Bruce Momjian 2003-03-18 00:29:59 Re: psql patch for datestyle