Re: [PATCHES] Non-colliding auto generated names

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Rod Taylor <rbt(at)rbt(dot)ca>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Non-colliding auto generated names
Date: 2003-03-06 02:30:28
Message-ID: 200303060230.h262USW01480@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Added to TODO:

> o Have ALTER TABLE rename SERIAL sequences

Seems we at least need this. Doesn't dependency tracking make this
easy to do now?

---------------------------------------------------------------------------

Tom Lane wrote:
> "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au> writes:
> >> I think we should stick with the existing naming convention.
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> > Non-colliding?
>
> No; see above.
>
> > Otherwise, it'd be ludicrous to fail a table rename because
> > a sequence with the new name already exists...
>
> Why? We already rename the table's rowtype, ergo you can fail a table
> rename because there is a conflicting datatype name. I don't see
> anything much wrong with failing a table or column rename because there
> is a conflicting sequence name. The whole point here is to have a
> non-surprising mapping between the names of serial columns and the names
> of their associated sequences.
>
> regards, tom lane
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-03-06 02:43:28 Purpose of core group
Previous Message Christopher Kings-Lynne 2003-03-06 02:21:36 Re: [GENERAL] problems with dropped columns

Browse pgsql-patches by date

  From Date Subject
Next Message greg 2003-03-06 15:31:41 Re: XML ouput for psql
Previous Message Christopher Kings-Lynne 2003-03-06 02:27:03 Re: new format for describe (repost #2)