Re: [HACKERS] lock.h and proc.h

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Sumaira Ali <nat_lazy(at)hotmail(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] lock.h and proc.h
Date: 2003-02-18 02:14:18
Message-ID: 200302180214.h1I2EIn04089@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Attached is a patch I just applied to clean this up. I didn't realize
how bad it was.

The reason for the name changes is that PROCLOCK is used by lock holders
and lock waiters.

---------------------------------------------------------------------------

Tom Lane wrote:
> "Sumaira Ali" <nat_lazy(at)hotmail(dot)com> writes:
> > hi..i have questions about struct pgproc (in file proc.h) and proclock ( in
> > file lock.h) of the postgresql source code, does anyone know the exact
> > difference between pgproc and proclock structs??
>
> There's one PGPROC per process. There's one PROCLOCK for each process
> and each lock that that process has any interest in (ie, either
> currently holds or is waiting for).
>
> The comments for these structs seem to be a bit of a mess at the moment :-(
> Bruce renamed the struct types recently, but appears not to have done a
> good job of adjusting the comments to match. It may help to know that
> a proclock object was formerly called a "holder".
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 50.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-02-18 02:20:24 Re: A couple of small fixes for 7.3.2 buglets
Previous Message Christopher Kings-Lynne 2003-02-18 01:34:02 Re: IpcSemaphoreKill: ...) failed: Invalid argument

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-02-18 02:21:23 Re: createuser - allow user cancel or kill to work
Previous Message Bruce Momjian 2003-02-17 22:17:28 Re: Patch to extend range of timestamps