From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: client_encoding directive is ignored in postgresql.conf |
Date: | 2003-02-14 22:19:55 |
Message-ID: | 200302142219.h1EMJtK15999@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> writes:
> > + /* Flag to we need to initialize client encoding info */
> > + static bool need_to_init_client_encoding = -1;
>
> Surely that should be int, not bool.
>
> > ! if (!PQsendQuery(conn, "begin; select pg_client_encoding(); commit"))
>
> Doesn't this break compatibility with pre-7.2 databases? AFAICT that
> function was introduced in 7.2.
I haven't seen this patch applied. If this is the best way to fix the
bug, we may as well break libpq for pre-7.2 clients.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2003-02-14 22:33:28 | Re: Brain dump: btree collapsing |
Previous Message | Bruce Momjian | 2003-02-14 22:17:22 | Re: location of the configuration files |