From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Lars Stenberg <lars(dot)stenberg(at)psycat(dot)net> |
Cc: | pgsql-jdbc(at)postgresql(dot)org |
Subject: | Re: Coding style |
Date: | 2003-02-03 01:06:00 |
Message-ID: | 200302030106.h13160i06623@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
It is in tools/pgindent, called pgjindent.
---------------------------------------------------------------------------
Lars Stenberg wrote:
> Hi!
>
> Just tell me if you need help when you are about to do it.
>
> Mvh
> Lars
> ----- Original Message -----
> From: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
> To: "Nic Ferrier" <nferrier(at)tapsellferrier(dot)co(dot)uk>
> Cc: "Lars Stenberg" <lars(dot)stenberg(at)psycat(dot)net>; <pgsql-jdbc(at)postgresql(dot)org>
> Sent: Monday, February 03, 2003 1:55 AM
> Subject: Re: [JDBC] Coding style
>
>
> >
> > Right. I do it just before every major release, but don't do it other
> > times becuase it causes too much of a diff.
> >
> > --------------------------------------------------------------------------
> -
> >
> > Nic Ferrier wrote:
> > > "Lars Stenberg" <lars(dot)stenberg(at)psycat(dot)net> writes:
> > >
> > > > Hi!
> > > >
> > > > I wonder if the project-owner want me to watch the entire jdbc source
> tree
> > > > and convert into a commonly used coding style. In A file i found at
> least
> > > > three different styles:
> > > >
> > > > 1) public java.sql.Time getTime(int parameterIndex) throws
> SQLException
> > > > {
> > > >
> > > > 2) public java.sql.Timestamp getTimestamp(int parameterIndex)
> > > > throws SQLException {
> > > >
> > > > 3) public void setUseServerPrepare(boolean flag) throws SQLException {
> > > >
> > > > Might be better if we all use a common codestyle like the third one?
> Anyhow,
> > > > if you want me to fix the code so it is consistent just tell me.
> > >
> > > I'm not one of the project owners... but I do hack on postgresql and I
> > > would rather you didn't do that.
> > >
> > > The reason is that doing a text mangle will cause revision tracking
> > > lossage, it's conveiniant sometimes to be able to scan backwards and
> > > forwards across the revision tree.
> > >
> > > I believe that postgresql jdbc code IS consistently indented, I for
> > > one don't really care what brace style is used.
> > >
> > >
> > > Nic
> > >
> > >
> > > ---------------------------(end of broadcast)---------------------------
> > > TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
> > >
> >
> > --
> > Bruce Momjian | http://candle.pha.pa.us
> > pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
> > + If your life is a hard drive, | 13 Roberts Road
> > + Christ can be your backup. | Newtown Square, Pennsylvania
> 19073
> >
>
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Bill Schneider | 2003-02-03 05:12:09 | PreparedStatement.setBytes on OIDs |
Previous Message | Lars Stenberg | 2003-02-03 00:59:07 | Re: Coding style |