Re: ecpg Oracle compatibility issue

OK, patch applied. Thanks.

---------------------------------------------------------------------------

Roland Karch wrote:
> On Thu, Dec 12, 2002 at 04:49:30PM -0500, Bruce Momjian wrote:
> > I applied the attached patch. Your version looked like it would have
> > doubled the double-quotes.
>
> Oops - yes, I got that wrong.
>
> > As you mentioned, you couldn't get bison to
> > work, so you weren't able to test it. Please look over this patch and
> > make sure it is correct.
>
> It works fine, just got bison to work on my other computer.
>
> > Also check the other use of ECPGdisconnect().
> > Is that correct? Does it need "CURRENT"?
>
> Yes, it's needed. Supplying a NULL pointer instead results in a segfault
> for me. However, it would work if src/interfaces/ecpg/lib/connect.c line
> 468 was patched - checking for NULL before dereferencing a user-supplied
> pointer is generally a good idea.
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073