Re: Geometry regression tests (was Re: [PATCHES] Alter domain)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Rod Taylor <rbt(at)rbt(dot)ca>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Geometry regression tests (was Re: [PATCHES] Alter domain)
Date: 2002-12-10 20:02:32
Message-ID: 200212102002.gBAK2Wh26674@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> That's a pain. Is there no way for config.guess to tell the difference
> >> between your system and the -STABLE versions?
>
> > As I remember, the issue is that the only info is in a system header
> > file.
>
> This is a bit of a kluge, but what about switching geometry over to the
> style Peter set up for locale differences? Instead of calling out
> platform-by-platform expected files, we could arrange it so that
> pg_regress will accept a match on-the-fly to either of two (or more,
> but I think two will be enough now) geometry.out files. Essentially
> we'd be saying that we don't really care whether specific platforms
> show positive or negative zeroes in that test.

I have to say I like this approach. ALl our regression files are valid
in some way.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-12-10 20:03:05 Re: psql's \d commands --- end of the line for 1-character identifiers?
Previous Message Tom Lane 2002-12-10 20:01:09 Geometry regression tests (was Re: [PATCHES] Alter domain)

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-12-10 20:03:05 Re: psql's \d commands --- end of the line for 1-character identifiers?
Previous Message Tom Lane 2002-12-10 20:01:09 Geometry regression tests (was Re: [PATCHES] Alter domain)