Re: [HACKERS] ALTER TABLE ... ADD COLUMN

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: alvherre(at)atentus(dot)com
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] ALTER TABLE ... ADD COLUMN
Date: 2002-10-19 02:43:30
Message-ID: 200210190243.g9J2hU629412@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Alvaro, I am seeing the attached regression failure, which I assume was
caused by your patch. Is the new regression output correct, or is there
something wrong?

---------------------------------------------------------------------------

pgman wrote:
>
> Patch applied. Thanks.
>
> ---------------------------------------------------------------------------
>
>
> Alvaro Herrera wrote:
> > En Fri, 4 Oct 2002 18:21:06 -0400
> > Alvaro Herrera <alvherre(at)atentus(dot)com> escribi?:
> >
> > > Huh, I don't know where I got the idea you were (or someone else was?)
> > > in the position that attislocal should be reset. I'll clean everything
> > > up and submit the patch I had originally made.
> >
> > All right, this is it. This patch merely checks if child tables have
> > the column. If atttypid and atttypmod are the same, the attributes'
> > attinhcount is incremented; else the operation is aborted. If child
> > tables don't have the column, recursively add it.
> >
> > attislocal is not touched in any case.
> >
> > --
> > Alvaro Herrera (<alvherre[a]atentus.com>)
> > "El Maquinismo fue proscrito so pena de cosquilleo hasta la muerte"
> > (Ijon Tichy en Viajes, Stanislaw Lem)
>
> [ Attachment, skipping... ]
>
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 6: Have you searched our list archives?
> >
> > http://archives.postgresql.org
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
> + If your life is a hard drive, | 13 Roberts Road
> + Christ can be your backup. | Newtown Square, Pennsylvania 19073

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 1.4 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2002-10-19 05:49:08 Re: [HACKERS] ALTER TABLE ... ADD COLUMN
Previous Message Bruce Momjian 2002-10-19 02:16:38 Re: contrib/dbmirror