Re: inline newNode()

Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
> > I don't like making the code GCC-specific any more than anyone else
> > does, but given that the code-bloat is specific to the inline version
> > of newNode (which in the scheme I described earlier would be
> > GCC-only) -- so introducing a GCC-specific fix for a GCC-specific
> > problem isn't too bad, IMHO.
>
> > Or we could just use your other suggestion: define a variant of
> > MemSet() and use it when we know it's safe. Not sure which is the
> > better solution: any comments?
>
> If we're going with a GCC-only approach to inlining newNode then it
> seems like a tossup to me too. Any other thoughts out there?

Seems newNode can easily be made into a macro. I can do the coding, and
if you tell me that newNode will always be int-aligned, I can make an
assume-aligned version of MemSet.

Is that what people want to try?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073