Re: [HACKERS] DROP COLUMN misbehaviour with multiple inheritance

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)atentus(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] DROP COLUMN misbehaviour with multiple inheritance
Date: 2002-09-23 01:31:01
Message-ID: 200209230131.g8N1V1I15763@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Patch applied by Tom.

---------------------------------------------------------------------------

Alvaro Herrera wrote:
> Alvaro Herrera dijo:
>
> > All right, I now have all the catalog changes on place; this is the easy
> > part (is an int2 count enough?).
> >
> > But when actually dropping a column, the recursion cannot be done the
> > way it's done now, fetching the whole inheritor tree in one pass,
> > because there's no way to distinguish the direct ones that have the
> > attisinherited count greater than 1 from deeper ones; it has to be done
> > step by step.
>
> Done. I attach the patch. It's huge because it needs to touch
> pg_attribute.h, but it is relatively simple. This passes the regression
> tests and fixes the bug reported by Hannu.
>
> Please review and apply if OK. I didn't touch catversion.h.
>
> --
> Alvaro Herrera (<alvherre[a]atentus.com>)
> "Cuando ma?ana llegue pelearemos segun lo que ma?ana exija" (Mowgli)

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-09-23 01:46:04 Re: ECPG
Previous Message Bruce Momjian 2002-09-23 00:48:54 Re: ECPG

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-09-23 01:38:07 Re: contrib/cube & contrib/seg regression fixes
Previous Message Neil Conway 2002-09-22 21:59:56 cleanup standard includes