From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Neil Conway <neilc(at)samurai(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, barry(at)xythos(dot)com, pgsql-bugs(at)postgresql(dot)org, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Bug #758: show_planner_stats does not work for new PREPARE |
Date: | 2002-09-18 04:54:50 |
Message-ID: | 200209180454.g8I4soX28704@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-patches |
[ Sorry, removed previous version of patch from queue.]
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
---------------------------------------------------------------------------
Neil Conway wrote:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> > I'm not sure why NDirectFileRead/NDirectFileWrite are unused at the
> > moment, but they used to be used; I think the correct response is to
> > put back the missing counter increments, not rip out the counters.
>
> Ok, fair enough. It's worth noting that they've been broken for a
> while -- for example, the HashJoin counter increments were broken when
> you comitted r1.20 of executor/nodeHashJoin.c in May of '99.
>
> I've attached a revised patch that doesn't remove the counters (but
> doesn't increment them either: I'm not sure of all the places where
> the counter should be incremented).
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Sean Chittenden | 2002-09-18 08:07:30 | Re: [NOVICE] Postgres storing time in strange manner |
Previous Message | Bruce Momjian | 2002-09-18 04:54:03 | Re: Bug #758: show_planner_stats does not work for new PREPARE |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2002-09-18 04:55:37 | Re: Doc patch |
Previous Message | Bruce Momjian | 2002-09-18 04:54:03 | Re: Bug #758: show_planner_stats does not work for new PREPARE |