From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Proposed GUC Variable |
Date: | 2002-09-02 05:41:27 |
Message-ID: | 200209020541.g825fRe13793@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
OK, attached patch applied. I made a few changes. I added a mention
they may want to enable LOG_PID because there is no guarantee that the
statement and error will appear next to each other in the log file. I
also renamed 'query' to 'statement' to be more precise.
Also, is there any way to disable this feature? I can't see how.
Also, you added this line:
+ extern bool Debug_print_error_query;
I assume it was a mistake.
---------------------------------------------------------------------------
Gavin Sherry wrote:
> On Thu, 29 Aug 2002, Tom Lane wrote:
>
> > Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> writes:
> > > That's a pretty good idea. Now, what format will the argument take: text
> > > (NOTICE, ERROR, DEBUG, etc) or integer? The increasing severity is clear
> > > with numbers but the correlation to NOTICE, ERROR etc is undocumented
> > > IIRC. On the other hand, the textual form is clear but INFO < NOTICE <
> > > WARNING < ERROR < FATAL, etc, is note necessarily obvious.
> >
> > The variable should take the same values as SERVER_MIN_MESSAGES and
> > impose the same priority order as it does. I would assume you could
> > share code, or at worst copy-and-paste a few dozen lines.
>
> A patch implementing this is attached. Instead of copy-and-pasting the
> code, I abstracted out of the lookup and converted the existing functions
> to use it.
>
> I was careful in elog() to ignore elog(LOG) calls when
> log_min_error_query >= LOG.
>
> Gavin
Content-Description:
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/plain | 14.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Joe Conway | 2002-09-02 05:45:43 | Re: Think I see a btree vacuuming bug |
Previous Message | Bruce Momjian | 2002-09-02 05:37:23 | Re: AutoCommit GUC breaks CLI tools... |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2002-09-02 05:43:53 | Re: contrib/tablefunc update |
Previous Message | Bruce Momjian | 2002-09-02 05:26:20 | Re: update to contrib/dblink |