| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Neil Conway <neilc(at)samurai(dot)com>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql-server/src backend/utils/adt/numutils.c ... |
| Date: | 2002-08-28 05:05:17 |
| Message-ID: | 200208280505.g7S55HD07623@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I don't even think it was ever a feature.
>
> It was certainly never documented as something that would work, unless
> you chanced to read the one comment in numutils.c. A normal person
> would not expect an empty string to be taken as a valid representation
> of "zero".
Well, assuming we are matching atoi, it would make sense to return 0 for
'', I think.
> > Let's see if we get any pushback. We can always downgrade it to a
> > warning during beta.
>
> I agree; tighten up and wait to see if anyone yowls.
Yes, we can loosen during beta, but not tighten.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2002-08-28 05:26:29 | Re: pgsql-server/src backend/utils/adt/numutils.c ... |
| Previous Message | Tom Lane | 2002-08-28 04:07:03 | Re: pgsql-server/src backend/utils/adt/numutils.c ... |