pgsql-server/src/backend/utils/adt oracle_compat.c

From: momjian(at)postgresql(dot)org (Bruce Momjian - CVS)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql-server/src/backend/utils/adt oracle_compat.c
Date: 2002-08-22 04:54:20
Message-ID: 20020822045420.E3B0A47672D@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: momjian(at)postgresql(dot)org 02/08/22 00:54:20

Modified files:
src/backend/utils/adt: oracle_compat.c

Log message:
repeat() fix:

> Neil Conway <neilc(at)samurai(dot)com> writes:
> > + /* Check for integer overflow */
> > + if (tlen / slen != count)
> > + elog(ERROR, "Requested buffer is too large.");
>
> What about slen == 0?

Good point -- that wouldn't cause incorrect results or a security
problem, but it would reject input that we should really accept.

Revised patch is attached.

Neil Conway

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian - CVS 2002-08-22 04:55:05 pgsql-server/src/backend/utils/adt oracle_compat.c
Previous Message Bruce Momjian - CVS 2002-08-22 04:52:17 pgsql-server/doc/src/sgml func.sgml runtime.sg ...