Re: @(#)Mordred Labs advisory 0x0003: Buffer overflow in PostgreSQL

Patch applied. Thanks.

---------------------------------------------------------------------------

Neil Conway wrote:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> > Neil Conway <neilc(at)samurai(dot)com> writes:
> > > + /* Check for integer overflow */
> > > + if (tlen / slen != count)
> > > + elog(ERROR, "Requested buffer is too large.");
> >
> > What about slen == 0?
>
> Good point -- that wouldn't cause incorrect results or a security
> problem, but it would reject input that we should really accept.
>
> Revised patch is attached.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073