From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: [HACKERS] Better handling of parse errors |
Date: | 2002-08-16 04:51:26 |
Message-ID: | 200208160451.g7G4pQI15169@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Gavin Sherry wrote:
> On Wed, 14 Aug 2002, Tom Lane wrote:
>
> > Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> writes:
> > > ... do we want to modify every 7.2 error message?
> >
> > Nyet ... but I don't think tacking an offset onto the end of
> > "parse error at or near foo" messages is likely to cause the
> > sort of generalized havoc you suggest ...
>
> In that case, attached is a patch which locates the beginning of the
> offending token more efficiently (per your suggestion of using
> scanbuf). The new patch does the same as before:
>
> template1=# select * frum pg_class;
> ERROR: parser: parse error at or near "frum" at character 10
>
> It also implement's Tom's suggestion:
>
> template1=# select * from pg_class where\g
> ERROR: parse: parse error at end of input
>
> Gavin
Content-Description:
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2002-08-16 04:55:08 | Re: Admin nice-to-have's |
Previous Message | Neil Conway | 2002-08-16 04:50:39 | Re: Admin nice-to-have's |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2002-08-16 04:55:49 | Re: improve SET CONSTRAINTS |
Previous Message | Bruce Momjian | 2002-08-16 04:50:36 | Re: updated lock listing patch |