Re: Antw: Re: Patch for NetWare support

We have to do that, at a minimum. I am trying to figure out how to get
this option in there without documentating it for the other 15+
platforms we support.

Most likely, we would define a port name in configure.in and test for
that before accepting that flag. Also, there would be _no_
documentation of this flags existance in the PostgreSQL documentation.
It is only used by the postmaster calling postgres, so that should be
OK.

I just wanted to make sure I understood the issues before moving forward
with your patches.

---------------------------------------------------------------------------

Ulrich Neumann wrote:
> Hi Bruce
>
> another solution can be to surround the patch with:
>
> #ifdef N_PLAT_NLM
> ...
> ...
> #endif
>
> Ulrich
>
> >>> "Ulrich Neumann" <U_Neumann(at)gne(dot)de> 12.08.2002 18:06:48 >>>
> Hi Bruce,
>
> at the moment NetWare doesn't have symbolic links so it's the only
> chance for me to decide between postmaster, bootstrap or normal
> interactive backend.
>
> Sorry for that. Novell will add symbolic and hard links to the file
> system
> but they don't have it yet. As soon as they have links we can remove
> the
> code.
>
> Ulrich
>
> >>> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> 09.08.2002 00:47:21 >>>
>
> I wish we didn't have to add this part of the patch to main.c:
>
> + /*
> + * If the first argument is "-post", then invoke postmaster
> mode. Note
> + * we remove "-post" from the arguments passed on to
> BootstrapMain.
> + * This is added for one reasons: NetWare doesn't have symbolic
> links
> + * right. ((
> + */
> + if (argc > 1 && strcmp(new_argv[1], "-post") == 0)
> + exit(PostmasterMain(argc - 1, new_argv + 1));
>
> Do we have to document this, but only for Netware? Yuck.
>
> ---------------------------------------------------------------------------
>
> Ulrich Neumann wrote:
> > Hello,
> >
> > attached is a patch for main.c.
> >
> > The files netware.h and netware.c are for src/backend/port/dynloader
> >
> > Can anybody create the directory netware at src/backend/port?
> >
> >
> > The changes in main.c are very small and i've documented them in the
> > sourcecode.
> >
> >
> > Thank you.
> >
> > Ulrich
> >
> > ----------------------------------
> > This e-mail is virus scanned
> > Diese e-mail ist virusgeprueft
>
> [ Attachment, skipping... ]
>
> [ Attachment, skipping... ]
>
> [ Attachment, skipping... ]
>
> >
> > ---------------------------(end of
> broadcast)---------------------------
> > TIP 1: subscribe and unsubscribe commands go to
> majordomo(at)postgresql(dot)org
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> + If your life is a hard drive, | 830 Blythe Avenue
> + Christ can be your backup. | Drexel Hill, Pennsylvania
> 19026
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to
> majordomo(at)postgresql(dot)org
> ----------------------------------
> This e-mail is virus scanned
> Diese e-mail ist virusgeprueft
>
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html
> ----------------------------------
> This e-mail is virus scanned
> Diese e-mail ist virusgeprueft
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073