| From: | Denis A Ustimenko <denis(at)oldham(dot)ru> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: timed PgConnection::Connect |
| Date: | 2002-08-09 09:48:57 |
| Message-ID: | 20020809094857.GB1210@denis.oldham.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Hi!
Here is rewrited version. Time out can be specified as "connect_timeout" parameter. API hadn't changed.
On Wed, Aug 07, 2002 at 09:52:05AM -0400, Tom Lane wrote:
> Denis A Ustimenko <denis(at)oldham(dot)ru> writes:
> > I write this to put timeout parameter in PgConnection::Connect.
>
> This patch seems really messy. In the first place, the timeout isn't on
> total connection delay, but on individual waits of which there will be
> several. I'd think that's not really what you want. In the second
> place, I'd expect a timeout to be specified as a new optional parameter
> in connection strings, not as an ad-hoc additional parameter in the API.
>
> regards, tom lane
--
Regards
Denis
| Attachment | Content-Type | Size |
|---|---|---|
| postgres-7.2.1-TIMED_CONNECT.patch | text/plain | 6.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2002-08-09 14:31:56 | Re: adding PGPASSWORDFILE to libpq |
| Previous Message | Gavin Sherry | 2002-08-09 09:22:52 | CREATE TEMP TABLE .... ON COMMIT |