From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Jan Wieck <JanWieck(at)Yahoo(dot)com>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [GENERAL] Stats Collector |
Date: | 2002-07-30 22:16:03 |
Message-ID: | 200207302216.g6UMG3D03978@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > A function seems like the wrong way to go on this. SET has super-user
> > protections we could use to control this but I am not sure what SET
> > syntax to use.
>
> I don't like SET for it --- SET is for setting state that will persist
> over some period of time, not for taking one-shot actions. We could
> perhaps use a function that checks that it's been called by the
> superuser.
>
> However, the real question is what is the use-case for this feature
> anyway. Why should people want to reset the stats while the system
> is running? If we had a clear example then it might be more apparent
> what restrictions to place on it.
Yep, I think Andrew explained possible uses. You may want to reset the
counters and run a benchmark to look at the results.
Should we have RESET clear the counter, perhaps RESET STATCOLLECTOR?
I don't think we have other RESET variables that can't be SET, but I
don't see a problem with it.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2002-07-30 22:24:34 | Re: [GENERAL] Stats Collector |
Previous Message | Andrew Sullivan | 2002-07-30 20:43:08 | Re: [GENERAL] Stats Collector |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2002-07-30 22:21:40 | Re: WAL file location |
Previous Message | Tom Lane | 2002-07-30 22:08:44 | Re: DROP COLUMN round 4 |