From: | nconway(at)klamath(dot)dyndns(dot)org (Neil Conway) |
---|---|
To: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | fmtId() and pg_dump |
Date: | 2002-07-24 23:21:32 |
Message-ID: | 20020724232132.GA17480@klamath.dyndns.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
The attached patch implements the scheme outlined on -hackers a little
while ago for reducing the usage of fmtId() in pg_dump. This is just
a "proof of concept" -- I added a simple wrapper over
appendPQExpBuffer() that takes an extra formatting sequence. The
implementation is pretty trivial -- the assumption is made that
(a) all printf-like formatting sequences consist of a '%' followed
by a single character
(b) any occurance of a '%' is a part of a formatting string
I've converted a few of the places where fmtId() is used over to the new
syntax. The reason I'm posting the patch is to get some feedback:
is this a better method can just calling fmtId()?
If so, I'll add some comments, convert all the code to use the wrapper
as necessary, and think up a better name for the wrapper function.
Cheers,
Neil
--
Neil Conway <neilconway(at)rogers(dot)com>
PGP Key ID: DB3C29FC
Attachment | Content-Type | Size |
---|---|---|
pg_dump_fmtid-4.patch | text/plain | 5.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Sabino Mullane | 2002-07-25 01:23:09 | Re: small psql patch - show Schema name for \dt \dv \dS |
Previous Message | Joe Conway | 2002-07-24 16:51:10 | Proposal: anonymous composite types for Table Functions (aka SRFs) |