Re: Unintegrated stuff in source tree

Peter Eisentraut wrote:
> There seems to have been an accumulation lately of stuff that was simply
> dumped into the source tree without any sort of integration. I am
> particularly talking about interfaces/ssl and interfaces/libpqxx. No
> doubt both of these things are useful in the end, but as they are right
> now they're a headache waiting to happen.
>
> Could someone try to address the following issues?
>
> SSL:
>
> * A bunch of cryptic configuration files -- what do they do?
>
> * Weird shell scripts -- what do they do?
>
> * The shell scripts are written in a completely unportable fashion and
> have inappropriate names (surely PostgreSQL isn't the only application in
> the world that allows to "mkcert").
>
> * They don't even belong into interfaces.
>
> * No build instructions, let alone a makefile.

I have requested info from the ssl author with no replies. Yank it from
CVS or I will do the honors.

> Libpqxx:
>
> * I'm no C++ whizz, but I guarantee that this coding style is not nearly
> as portable as we've tried to make libpq++ be. Who wants to answer those
> support calls all over again?
>
> * What's the deal with libpq++ vs. libpqxx? Who's going to want to
> explain that to the crowd for the next 5 years?
>
> * Bogus Automake stuff -- hurts my eyes. ;-)
>
> * Doxygen -- is that going to be a quasi-required tool now?
>
> * Bonus points for documentation in DocBook format -- but unfortunately
> version 4.1, and unfortunately not integrated with the rest of the
> documentation set.
>
> * No build integration.
>
> * Why are half the text files executable?
>
> Personally, I'm uneasy about carrying around another interface library
> that appears to have no basis in any sort of standard.

The idea was that someone with more knowledge of PostgreSQL would
integrate the new C++ interface into our build system. If it doesn't
happen, we will yank it before 7.3.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026