Re: BETWEEN Node & DROP COLUMN

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BETWEEN Node & DROP COLUMN
Date: 2002-07-04 02:18:27
Message-ID: 200207040218.g642IS010518@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Christopher Kings-Lynne wrote:
> > > > > Yes, please remind me. Was your solution renumbering the
> > attno values?
> > > >
> > > > Yes though I don't intend to object to Christopher's proposal.
>
> Hiroshi,
>
> I am thinking of rolling back my CVS to see if there's code from your
> previous test implementation that we can use. Apart from the DropColumn
> function itself, what other changes did you make? Did you have
> modifications for '*' expansion in the parser, etc.?

Yes, please review Hiroshi's work. It is good work. Can we have an
analysis of Hiroshi's approach vs the isdropped case.

Is it better to renumber the attno or set a column to isdropped. The
former may be easier on the clients.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christopher Kings-Lynne 2002-07-04 02:40:50 Re: BETWEEN Node & DROP COLUMN
Previous Message Christopher Kings-Lynne 2002-07-04 02:11:36 Adding attisdropped