Re: [PATCHES] Reduce heap tuple header size

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Manfred Koizar <mkoi-pg(at)aon(dot)at>, Curt Sampson <cjs(at)cynic(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Reduce heap tuple header size
Date: 2002-07-02 06:16:29
Message-ID: 200207020616.g626GUf04779@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Manfred Koizar <mkoi-pg(at)aon(dot)at> writes:
> > ... I wonder
> > whether we shouldn't apply this second version (without the configure
> > parts) and put all forthcoming format changes under #ifndef
> > PG72FORMAT.
>
> Seems reasonable. I generally dislike #ifdef clutter, but the #ifs
> would only be around a couple of macro definitions AFAICT, so the
> readability hit would be minimal. And someone who wanted
> back-compatibility would be able to have it, whichever way we jump
> on the decision for 7.3.

I committed the version with no #ifdef's. If we need them, we can add
them later, but it is likely we will never need them.

> At the rate Manfred is going, he'll have patches for all the tuple and
> page header related issues before August anyway ... so my original gripe
> about wanting to group those changes into a single release will become
> moot ;-). I certainly have no objection to doing them all in 7.3
> instead of 7.4 if we can get it done.

Yes. Manfred, keep going. ;-)

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-07-02 06:18:43 Re: [HACKERS] Page OpaqueData
Previous Message Bruce Momjian 2002-07-02 05:46:28 Re: Reduce heap tuple header size

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-07-02 06:18:43 Re: [HACKERS] Page OpaqueData
Previous Message Bruce Momjian 2002-07-02 05:49:46 Re: pg_dump: fix 2 memory leaks