Re: Small changes to facilitate Win32 port

Christopher Kings-Lynne wrote:
> It's more likely that your changes will go through if you just submit a
> patch!

I suggested to discuss it first, since it's IMHO more likely
that the changes go through if they are commonly accepted in
the first place.

Jan

> cvs diff -c
>
> Chris
>
> ----- Original Message -----
> From: "Katherine Ward" <kward6(at)yahoo(dot)com>
> To: <pgsql-hackers(at)postgresql(dot)org>
> Sent: Thursday, May 30, 2002 2:33 PM
> Subject: [HACKERS] Small changes to facilitate Win32 port
>
>
> > Hi there. I'm yet another developer working full-time on a native windows
> > port. I'm also working closely with Jan Wieck (next office). I know
> there is
> > a reluctance to modify the code base to support native win32, and I
> realize
> > that no decision has yet been made. However, ...
> >
> > A few of the identifier names used in postgres collide with WIN32 or MFC
> names.
> > To keep my working copy of the code as close to the released source as
> > possible, I do have some superficial changes that I would like to put in
> the
> > code base early:
> >
> > 1. Rename to avoid structures/functions with same name:
> > a. PROC => PGPROC
> > b. GetUserName() => GetUserNameFromId()
> > c. GetCurrentTime() => GetCurrentDateTime()
> >
> > 2. Add _P to the following lex/yacc tokens to avoid collisions
> > CONST, CHAR, DELETE, FLOAT, GROUP, IN, OUT
> >
> > 3. Rename two local macros
> > a. MEM_FREE => MEM_FREE_IT in backend/utils/hash/dynahash.c
> > b. IGNORE => IGNORE_TOK in include/utils/datetime.h &
> > backend/utils/adt/datetime.c
> >
> > Thanks,
> > Katie Ward
> > kward6(at)yahoo(dot)com
> >
> >
> > __________________________________________________
> > Do You Yahoo!?
> > Yahoo! - Official partner of 2002 FIFA World Cup
> > http://fifaworldcup.yahoo.com
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 5: Have you checked our extensive FAQ?
> >
> > http://www.postgresql.org/users-lounge/docs/faq.html
> >
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #