| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] WITH DELIMITERS in COPY |
| Date: | 2002-04-16 23:49:45 |
| Message-ID: | 200204162349.g3GNnj527600@candle.pha.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Oh, I think we were talking at cross-purposes then. What you're really
> unhappy about is that this uses a list of two-element sublists? Yeah,
> I agree, that's a messy data structure; a list of DefElem would be
> perhaps cleaner. Not sure if it matters all that much though, since the
> list only exists in the context of a few productions in gram.y. Perhaps
> adding a couple of lines of documentation would be better than changing
> the code.
Yea, documenation and/or a list of DefElem would be nicer. The problem
is that people are going to copy this in the future, so I may as well do
it right. Can't take more than 20 minutes.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-04-16 23:55:25 | Re: [PATCHES] WITH DELIMITERS in COPY |
| Previous Message | Tom Lane | 2002-04-16 23:34:17 | Re: [PATCHES] WITH DELIMITERS in COPY |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-04-16 23:55:25 | Re: [PATCHES] WITH DELIMITERS in COPY |
| Previous Message | Tom Lane | 2002-04-16 23:34:17 | Re: [PATCHES] WITH DELIMITERS in COPY |