Re: numeric/decimal docs bug?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Jan Wieck <janwieck(at)yahoo(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org, Jan Wieck <JanWieck(at)yahoo(dot)com>
Subject: Re: numeric/decimal docs bug?
Date: 2002-04-13 01:39:09
Message-ID: 200204130139.g3D1d9k13453@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jan Wieck wrote:
> > Oh, interesting, maybe we should just leave it alone.
>
> As said, I have to look at the code. I'm pretty sure that it
> currently will not use hundreds of digits internally if you
> use only a few digits in your schema. So changing it isn't
> that dangerous.
>
> But who's going to write and run a regression test, ensuring
> that the new high limit can really be supported. I didn't
> even run the numeric_big test lately, which tests with 500
> digits precision at least ... and therefore takes some time
> (yawn). Increasing the number of digits used you first have
> to have some other tool to generate the test data (I
> originally used bc(1) with some scripts). Based on that we
> still claim that our system deals correctly with up to 1,000
> digits precision.
>
> I don't like the idea of bumping up that number to some
> higher nonsense, claiming we support 32K digits precision on
> exact numeric, and noone ever tested if natural log really
> returns it's result in that precision instead of a 30,000
> digit precise approximation.
>
> I missed some of the discussion, because I considered the
> 1,000 digits already beeing complete nonsense and dropped the
> thread. So could someone please enlighten me what the real
> reason for increasing our precision is? AFAIR it had
> something to do with the docs. If it's just because the docs
> and the code aren't in sync, I'd vote for changing the docs.

Jan, if the numeric code works on 100 or 500 digits, could it break with
10,000 digits. Is there a reason to believe longer digits could cause
problems not present in shorter tests?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-04-13 01:40:18 Re: pg_dump is broken in CVS tip
Previous Message Bruce Momjian 2002-04-13 01:37:34 Re: numeric/decimal docs bug?