Re: pg_dump is broken in CVS tip

On Fri, 12 Apr 2002 19:24:21 -0400
"Neil Conway" <nconway(at)klamath(dot)dyndns(dot)org> wrote:
> When I built the current CVS code, both test-case exhibits the
> problem quite obviously. Therefore, it seems that the problem
> has been introduced recently.

The problem was introduced here:

------------------
revision 1.246
date: 2002/04/05 11:51:12; author: momjian; state: Exp; lines: +129 -3
Adds domain dumping support to pg_dump.

Rod Taylor
------------------

Rod's patch does what it is supposed to do, but it also includes
some old code to add PK constraints to CREATE TABLE. That stuff
had been removed as part of my original patch for pg_dump a
little while ago.

The attached patch fixes this by removing (again :-) ) the
code in dumpTables() to perform PK creation during CREATE
TABLE. I briefly tested it locally and it fixes both of
Tom's test cases.

Please apply.

Cheers,

Neil

--
Neil Conway <neilconway(at)rogers(dot)com>
PGP Key ID: DB3C29FC