Re: Locale support is now on by default

Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > > There doesn't seem to be a way to turn off LOG without hiding almost
> > > everything:
> > >
> > > if (lev == LOG || lev == COMMERROR)
> > > {
> > > if (server_min_messages == LOG)
> > > output_to_server = true;
> > > else if (server_min_messages < FATAL)
> > > output_to_server = true;
> > > }
> > >
> > > Everything except for PANIC is less than FATAL, so this doesn't make sense
> > > to me.
> >
> > Actually, what this is saying is that for an elog(LOG) to show, the
> > server_min_messages, must be less than FATAL.
>
> I know what this is saying, but the coding is redundant (since LOG is also
> less than FATAL).

Sure, but the ordinal value of log is different for client and server:

#server_min_messages = notice # Values, in order of decreasing detail:
# debug5, debug4, debug3, debug2, debug1,
# info, notice, warning, error, log, fatal,
# panic
#client_min_messages = notice # Values, in order of decreasing detail:
# debug5, debug4, debug3, debug2, debug1,
# log, notice, warning, error

The LOG value is ordinally correct for CLIENT, but for SERVER, it is
just below FATAL. I can change it but for now that is what people
wanted, meaning you probably want LOG in the log file before WARNINGS or
even ERROR.

>
> > Setting server_min_messages to FATAL means only FATAL and PANIC
> > appear:
> >
> > Server levels are:
> >
> > # debug5, debug4, debug3, debug2, debug1,
> > # info, notice, warning, error, log, fatal, panic
>
> I don't recall log being so high. Didn't it use to be after info?
> Certainly there should be a way to see only warnings, errors, and higher
> without seeing the "unimportant" log messages. Actually, I'm also
> confused why we now have info, notice, *and* warning. Shouldn't two of
> these be enough?

We added NOTICE and INFO and WARNING because they were required. INFO
is for SET-like information, NOTICE is for non-warnings like sequence
creation for SERIAL, and WARNING is for real warnings like identifier
truncation.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026