Re: create function problem

From: Jan Wieck <janwieck(at)yahoo(dot)com>
To: "Kancha (dot)" <kancha2np(at)yahoo(dot)com>
Cc: Matteo Beccati <m(dot)beccati(at)crpsoftware(dot)it>, pgsql-sql(at)postgresql(dot)org
Subject: Re: create function problem
Date: 2002-03-19 14:25:37
Message-ID: 200203191425.g2JEPcL08516@saturn.janwieck.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-sql

Kancha . wrote:
>
> > Hi,
> >
> > > create function usage(text)
> > > returns numeric
> > > as 'select ceil(sum(sessiontime)/60) from
> > ath_online
> > > where loginname=\'$1\' and startdate >= (select
> > > startdate from cst_package where status=\'t\' and
> > > cid=(select cid from cst_customer where
> > > loginname=\'$1\'));'
> > > language 'sql';
> >
> > Try to replace \'$1\' with just $1 (i.e. loginname =
> > $1).
> >
>
> the argument is a string so it has to be enclosed in
> quotes and \ is to escape the quote. replacing with
> just $1 will give error like following:

The argument is a string and $1 becomes a T_Param node of
type "text" in your case, which is a perfectly valid string
without the quotes. Don't get confused by the $ sign in the
parameter name. $1 is treated like a variable name.

Just try "exactly" what was suggested, including the
whitespaces surrounding the = operator. Write

loginname = $1

instead of

loginname=$1

This does not only make the code more readable for humans.
The parser likes it too.

Jan

>
> Unable to identify an operator '=$' for types
> 'varchar' and 'int4'
> You will have to retype this query using an
> explicit cast
>
>
>
> __________________________________________________
> Do You Yahoo!?
> Yahoo! Sports - live college hoops coverage
> http://sports.yahoo.com/
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org
>

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #

_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com

In response to

Browse pgsql-sql by date

  From Date Subject
Next Message Tom Lane 2002-03-19 15:28:42 Re: optimizer tuning/forcing correct index use
Previous Message Kelly Burkhart 2002-03-19 13:22:49 optimizer tuning/forcing correct index use