From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Fernando Nasser <fnasser(at)redhat(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Broken code in gram.y |
Date: | 2002-03-19 12:53:21 |
Message-ID: | 200203191253.g2JCrLi14552@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thanks. Fixed.
---------------------------------------------------------------------------
Fernando Nasser wrote:
> Well,
>
> Someone just dropped the DROP DATABASE statement rules right in the
> middle of the CREATE DATABASE production rules!!!
>
> Fernando
>
>
>
> Fernando Nasser wrote:
> >
> > The OWNER production rules added to DROP DATABASE:
> >
> > DropdbStmt: DROP DATABASE database_name
> > {
> > DropdbStmt *n =
> > makeNode(DropdbStmt);
> > n->dbname = $3;
> > $$ = (Node *)n;
> > }
> > | OWNER opt_equal name
> > {
> > $$ = lconsi(4, makeList1($3));
> > }
> > | OWNER opt_equal DEFAULT
> > {
> > $$ = lconsi(4, makeList1(NULL));
> > }
> > ;
> >
> > Cause compiler warnings and are clearly returning the wrong type
> > (a List, instead of a Node).
> >
> > (...)/pgsql/src/backend/parser/gram.y: In function
> > `yyparse':/home/fnasser/DEVO/pgsql/pgsql/src/backend/parser/gram.y:3205:
> > warning: assignment from incompatible pointer type
> > (...)/pgsql/src/backend/parser/gram.y:3209: warning: assignment from
> > incompatible pointer type
> >
> > --
> > Fernando Nasser
> > Red Hat Canada Ltd. E-Mail: fnasser(at)redhat(dot)com
> > 2323 Yonge Street, Suite #300
> > Toronto, Ontario M4P 2C9
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 5: Have you checked our extensive FAQ?
> >
> > http://www.postgresql.org/users-lounge/docs/faq.html
>
> --
> Fernando Nasser
> Red Hat Canada Ltd. E-Mail: fnasser(at)redhat(dot)com
> 2323 Yonge Street, Suite #300
> Toronto, Ontario M4P 2C9
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Marc G. Fournier | 2002-03-19 13:10:40 | Re: Time for 7.2.1? |
Previous Message | Bruce Momjian | 2002-03-19 12:52:56 | Re: bug in domain support |