Re: Bad Build

Bruce Momjian wrote:
> Tom Lane wrote:
> > Neil Conway <nconway(at)klamath(dot)dyndns(dot)org> writes:
> > > Yes, I see this as well.
> >
> > By my count the breakage from the DOMAIN patch is:
> > 1 shift/reduce conflict in gram.y
> > 3 gcc warnings (at least one being obviously a bug)
> > 1 core dump during regression tests
> >
> > Bruce, what in the heck were you doing applying this patch? You knew
> > darn well it had not been meaningfully reviewed. Not bothering to check
> > for compile problems or regression failures before applying is
> > unforgivably sloppy work. I don't blame the submitter; I blame you,
> > who should have known better.
>
> You can blame me all you want. That was in the queue, and no one
> objected, so I did my best. If you don't want to forgive me, don't.
>
> In fact, this whole indignation thing is starting to tire me. This is an
> open-source project. People do the best they can. Just make the best of
> it and move on.
>
> If this is the worst that has happened from my applying all those back
> patches, I am happy.

Sorry Bruce, but just because your patch queue is very long
due to the delays in the 7.2 release cycle is no excuse to
work sloppy now. Rushing things in is not the solution.

Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #

_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com