Re: [jason@netspade.com: DatabaseMetaData.java.diff]

Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours. JDBC maintainers will
review.

---------------------------------------------------------------------------

Jason Davies wrote:

Checking application/pgp-signature: FAILURE
-- Start of PGP signed section.
> Dave,
>
> Here is yet another patch for DatabaseMetaData which does several things:
> a) Currently an extra key is returned in both getExportedKeys() and getImportedKeys(). So a foreign key relationship, duplicate keys are returned. This has been fixed.
> b) PK_NAME is now returned.
> c) The whole SQL query has been optimized (no more ugly inner selects).
> d) The getExportedKeys() and getImportedKeys() implementation has been put into a single getImportedExportedKeys() to save duplcating the code.
> e) KEY_SEQ is now also returned.
>
> There is however one problem to do with multiple foreign key columns. Should they be returned as a single row, separated by commas? Or returned in separate rows? By multiple foreign key columns I mean, "alter table ptable add constraint ptable_fkey foreign key (pcol1, pcol2) references ftable (fcol1, fcol2)".
>
> I think returning separate rows is the most correct way to do it, assuming the SQL statement above is equivalent to 2 separate fkeys.
>
> Any comments are welcome,
>
> Jason
>
> On Fri, Nov 02, 2001 at 07:04:16PM -0500, Dave Cramer wrote:
> > Jason,
> >
> > The current sources should be patched as per your patch. I also fixed
> > jdbc1 so it would compile
> >
> > Dave
> >
> > -----Original Message-----
> > From: pgsql-jdbc-owner(at)postgresql(dot)org
> > [mailto:pgsql-jdbc-owner(at)postgresql(dot)org] On Behalf Of Jason Davies
> > Sent: November 2, 2001 5:16 PM
> > To: Dave Cramer
> > Cc: PostgreSQL JDBC
> > Subject: [JDBC] [jason(at)netspade(dot)com: DatabaseMetaData.java.diff]
> >
> >
> >
> > Sorry, I forgot to attach the file. How embarrassing :)
> >
> > --
> > Jason Davies
> >
> > jason(at)netspade(dot)com
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 2: you can get off all lists at once with the unregister command
> > (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>
> --
> Jason Davies
>
> jason(at)netspade(dot)com

[ Attachment, skipping... ]
-- End of PGP section, PGP failed!

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026