Re: Patch pgsql-7.2 AuthBlockSig

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Heiko Lehmann <hlehmann(at)fh-lausitz(dot)de>
Cc: pgsql-bugs(at)postgresql(dot)org, Iris Ladusch <iladusch(at)fh-lausitz(dot)de>, Thomas Scholze <tscholze(at)fh-lausitz(dot)de>
Subject: Re: Patch pgsql-7.2 AuthBlockSig
Date: 2002-02-22 15:38:09
Message-ID: 200202221538.g1MFc9m08640@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs


Good catch. I see now that AuthBlockSig is missing in
/src/include/pgsignal.h, but is referenced in pgsignal.c in both #ifdef
and #else cases.

Patch applied to 7.3 and will appear in 7.2.1.

---------------------------------------------------------------------------

Heiko Lehmann wrote:
> HAllo!
>
> We had a problem with to compile pgsql-7.2 under SW-8.0.
> In the mailing lists I found no informations.
> See note for further informations.
>
> regards Heiko
>
>
> (part of 020221.postgresql-7.2)
> ## ----------------------------------------------------------------------
> ## Problem AuthBlockSig
> ## - linux-2.4.14, sw-8.0, gcc-2.95.3
> # make
> ...
> gcc -O2 -Wall -Wmissing-prototypes -Wmissing-declarations
> -I../../../src/include
> -c -o pqsignal.o pqsignal.c
> pqsignal.c: In function `pqinitmask':
> pqsignal.c:122: `AuthBlockSig' undeclared (first use in this function)
> pqsignal.c:122: (Each undeclared identifier is reported only once
> pqsignal.c:122: for each function it appears in.)
> make[3]: *** [pqsignal.o] Error 1
> make[3]: Leaving directory `/var/tmp/postgresql-7.2/src/backend/libpq'
> make[2]: *** [libpq-recursive] Error 2
> make[2]: Leaving directory `/var/tmp/postgresql-7.2/src/backend'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/var/tmp/postgresql-7.2/src'
> make: *** [all] Error 2
> ## Define fuer AuthBlockSig scheint zu fehlen. Bug?!
> ## in pqsignal.h existieren 2 verschiedene Definitionen
> ## folgenden Patch einspielen:
> ## ---%<---
> *** ./src/include/libpq/pqsignal.h.org Mon Nov 5 18:46:33 2001
> --- ./src/include/libpq/pqsignal.h Thu Feb 21 18:51:39 2002
> ***************
> *** 28,34 ****
> #define PG_SETMASK(mask) sigprocmask(SIG_SETMASK, mask, NULL)
> #else
> extern int UnBlockSig,
> ! BlockSig;
>
> #define PG_SETMASK(mask) sigsetmask(*((int*)(mask)))
> #endif
> --- 28,35 ----
> #define PG_SETMASK(mask) sigprocmask(SIG_SETMASK, mask, NULL)
> #else
> extern int UnBlockSig,
> ! BlockSig,
> ! AuthBlockSig;
>
> #define PG_SETMASK(mask) sigsetmask(*((int*)(mask)))
> #endif
> ## ---%<---
> ## nun ist der Fehler weg. OK.
> ## --> mailto:pgsql-bugs(at)postgresql(dot)org
> ## ----------------------------------------------------------------------
>
>
>
>
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Attachment Content-Type Size
unknown_filename text/plain 758 bytes

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2002-02-22 15:59:37 Re: Patch pgsql-7.2 AuthBlockSig
Previous Message Tom Lane 2002-02-22 15:29:50 Re: Now trying Cygwin with normal download of PostgreSQL