Re: elog cleanup

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Serguei Mokhov <mokhov(at)cs(dot)concordia(dot)ca>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: elog cleanup
Date: 2002-02-19 05:41:53
Message-ID: 200202190541.g1J5frp12303@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Serguei Mokhov wrote:
> ----- Original Message -----
> From: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
> Sent: Tuesday, February 19, 2002 12:16 AM
>
> ...
>
> > ! elog(CRASH, "heap_delete_%sdo: no block", (redo) ? "re" : "un");
> > ! elog(CRASH, "heap_delete_%sdo: uninitialized page", (redo) ? "re" : "un");
>
> ...
>
> This type of "dynamically constructed" messages is kinda bad for translators,
> because the parts one's replacing in the original message could be
> translated differently entirely and may not suit in the translations as they do in the originals.
> Even if they do, "re" and "un" will never make into the message catalogs, for example.
>
> Maybe it's not so crucial for these specific messages, but for sure won't
> work for general type of messages.

This is a good point. I am not too concerned about this case because it
is attempting to match an actual function name. I hope we don't do this
for more general messages. My guess is that we don't, because if we
did, some translator would have complained. :-)

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-02-19 05:43:06 Re: elog cleanup
Previous Message Bruce Momjian 2002-02-19 05:40:01 Re: elog cleanup