| From: | hiroyuki hanai <hanai(at)imgsrc(dot)co(dot)jp> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: compile error of PostgreSQL 7.2 on FreeBSD-current |
| Date: | 2002-02-08 16:08:57 |
| Message-ID: | 20020209.010857.42778788.hanai@imgsrc.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 8 Feb 2002, Bruce Momjianwrote:
> > How about including <sys/types.h> before including
> > <grp.h> in src/backend/utils/init/findbe.c?
> >
> > I've just compiled 7.2 on FreeBSD-current, which has failed
> > with compilation error because the type of gr_gid in struct group
> > is gid_t on FreeBSD-current.
>
> sys/types.h include is in 7.2. Please upgrade.
Bruce, I know sys/types include is in 7.2.
I'm talking about the order to include header files.
src/backend/utils/init/findbe.c in 7.2 includes <grp.h>
*before* <sys/types.h>.
But, the type of gr_gid in struct group, which is defined
in <grp.h>, is gid_t. So, <sys/types> should be inclueded
before <grp.h>
The type of gr_gid in <grp.h> was `int' before 22th Jan 2002.
It has been changed as gid_t by Mark Murray on 22th Jan 2002.
Regards,
hiro hanai
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthew T. O'Connor | 2002-02-08 16:17:29 | Re: Why dump/restore to upgrade? |
| Previous Message | Tom Lane | 2002-02-08 15:39:06 | Re: 7.2 - changed array_out() - quotes vs no quotes |