Re: Bug in pg_dump/restore -o

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > My only comment here is that I don't see a need to set the oid counter
> > for a schema-only restore because there are no oid's in the schema dump
> > anyway.
>
> Given a pg_dump archive containing OIDs, I would expect a schema-only
> pg_restore followed by a data-only pg_restore to produce the same end
> result as a schema+data restore, no?

That is the big question, if they are doing a schema-only restore, will
then then do a data-only restore, or will they not. My guess is that
they will not or they would have just restored the whole thing.

The downside of setting the oid counter on schema-only is that you have
set the counter much higher than they may have wanted, especially if
they are doing the schema-only restore to somehow get the counter down
again. The downside of _not_ setting the oid counter on schema-only is
that they may have duplicate oids between system and user tables. That
seems less of a risk than the former, and much less likely to happen.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026