From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Marko Kreen <marko(at)l-t(dot)ee>, Thomas Lockhart <lockhart(at)fourpalms(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: make createlang match docs |
Date: | 2002-01-03 06:08:30 |
Message-ID: | 200201030608.g0368UP15445@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
> I was going to add this to TODO:
>
> Change 'createlang [langname] dbname' to 'createlang langname [dbname]'
>
> However, when I started to look at the createlang script, I saw:
>
> if [ "$list" != "t" ]
> then langname="$1"
> if [ "$2" ]
> then
> shift
> dbname="$1"
> fi
> else dbname="$1"
> fi
>
> which said that dbname was already behaving as optional, even though
> there was code to handle a missing langname.
>
> Rather than change the script to make langname optional, I have fixed
> the script to work the way everyone wants it to work, namely dbname is
> now optional. I grabbed the dbname default code from createdb.
OK, turns out droplang has the same problem; default are documented but
do not work. Fixed to have dbname optional, just like createlang.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/plain | 4.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2002-01-03 07:57:54 | Re: Patch for ODBC driver (look for odbc.ini in more than |
Previous Message | Bruce Momjian | 2002-01-03 05:45:13 | Re: make createlang match docs |