Re: pgsql: Add TAP tests for contrib/sslinfo

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-committers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pgsql: Add TAP tests for contrib/sslinfo
Date: 2021-12-01 22:43:57
Message-ID: 2001386.1638398637@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, Dec 01, 2021 at 04:04:09PM -0500, Tom Lane wrote:
>> I agree that some docs about this would be nice, but I think the rules
>> for when to use perl2host are more complex than what you suggest here.
>> Perhaps Andrew can clarify.

> It seems to me that the rule applies to any paths passed down to the C
> code of Postgres, then processed by a system call.

I'm a little gun-shy of any sweeping statements here, because of
bad experience (27ab1981e, b35a67bc0). It's as important to be
clear about when *not* to use perl2host as when to do so.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2021-12-02 01:33:31 pgsql: Move into separate file all the SQL queries used in pg_upgrade t
Previous Message Michael Paquier 2021-12-01 22:37:49 Re: pgsql: Add TAP tests for contrib/sslinfo