Re: OCTET_LENGTH is wrong

> > > BTW, I noticed that textlength() is absolutely unreasonably slow when
> > > MULTIBYTE is enabled --- yesterday I was trying to profile TOAST
> > > overhead, and soon discovered that what I was looking at was nothing
> > > but pg_mblen() calls. It really needs a short-circuit path for
> > > single-byte encodings.
> >
> > It's easy to optimize that. However I cannot access CVS anymore after
> > the IP address change. Will post patches later...
>
> Seems I got the cvs access again (I was asked my pass phrase again)
> and I have committed changes for this.
>
> Modified functions are:
>
> bpcharlen
> textlen
> varcharlen

Did you go with the pre or post-TOAST length for these types? I vote
for pre-TOAST because it seems much more useful to ordinary users.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026