Re: Open Items (was: RE: [HACKERS] Beta going well)

> > The only problem I have now is that odbc/md5.h needs those unsigned
> > defines and it can't probe the results of queries by configure. odbc
> > allows for stand-alone compile.
>
> ODBC uses all kinds of other configure results, so it can use this one as
> well. You only need to make sure you hard-code the test result for
> Windows somewhere.

Good point, Peter. I had not seen that psqlodbc.h does conditionally
include pg_config.h. I have added this test to md5.h:

/* Also defined in include/c.h */
#if SIZEOF_UINT8 == 0
typedef unsigned char uint8; /* == 8 bits */
typedef unsigned short uint16; /* == 16 bits */
typedef unsigned int uint32; /* == 32 bits */
#endif /* SIZEOF_UINT8 == 0 */

In the case of WIN32, SIZEOF_UINT8 is not defined, so it should compare
equal to zero, and should include those defines, as needed. It now
matches c.h. Is that OK?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026