| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> | 
|---|---|
| To: | Zeugswetter Andreas SB SD <ZeugswetterA(at)spardat(dot)at> | 
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, peter_e(at)gmx(dot)net, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org | 
| Subject: | Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well) | 
| Date: | 2001-11-15 16:35:44 | 
| Message-ID: | 200111151635.fAFGZic03096@candle.pha.pa.us | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches | 
OK, I backed out your previous patch and applied this one.
Thanks.
---------------------------------------------------------------------------
> 
> > "Zeugswetter Andreas SB SD" <ZeugswetterA(at)spardat(dot)at> writes:
> > 
> >   /* Plain "long int" fits, use it */
> > + #if SIZEOF_INT8 == 0
> >   typedef long int int64;
> > + #endif
> > + #if SIZEOF_UINT8 == 0
> >   typedef unsigned long int uint64;
> > + #endif
> >   
> > 
> > This coding appears to assume "if the platform defines int8, then
> > it will define int64 as well".  Seems mighty fragile to me.
> 
> Well the absolute correct solution would involve all of:
> int8, int16, int32, int64 and separately uint8, uint16, uint32, uint64
> 
> The previous patch grouped:
> int8, int16 and int32
> uint8, uint16 and uint32
> int64 and uint64  <-- this grouping is wrong on AIX 4.3.3 and below
> 
> If you prefer to make 4 groups out of this you could apply this patch.
> 
> Andreas
Content-Description: int8-newpatch2
[ Attachment, skipping... ]
-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2001-11-15 16:36:16 | Re: [DOCS] Use of 'now' | 
| Previous Message | Tom Lane | 2001-11-15 16:30:16 | Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well) | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bill Studenmund | 2001-11-16 03:21:23 | Re: Patch to add Heimdal kerberos support | 
| Previous Message | Tom Lane | 2001-11-15 16:30:16 | Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well) |