Re: ALTER TABLE RENAME fix

From: Brent Verner <brent(at)rcfile(dot)org>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: ALTER TABLE RENAME fix
Date: 2001-11-12 19:38:55
Message-ID: 20011112143855.A2446@rcfile.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On 12 Nov 2001 at 18:28 (+0100), Peter Eisentraut wrote:
| Brent Verner writes:
|
| > These patches fix the problem where an
| >
| > ALTER TABLE <table> RENAME <oldcolumn> TO <newcolumn>
| >
| > did not update the RI_ triggers if the oldcolumn was referenced in
| > a RI constraint.
|
| Instead of trying to fix this, how about making the RI triggers not use
| the column names in the first place. (Instead they should use the oid of
| the table and the attnums.)

I agree with you. Two things led me toward the current approach
(modifying tgargs)
1) it would require fewer changes to get correct behavior, which
was important as late in beta as I started and
2) I had /some/ idea of how to get it done ;-)

I'll begin to look at what would be required to do it the right
way for 7.3.

cheers.
brent

--
"Develop your talent, man, and leave the world something. Records are
really gifts from people. To think that an artist would love you enough
to share his music with anyone is a beautiful thing." -- Duane Allman

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-11-12 20:26:21 Re: ALTER TABLE RENAME fix
Previous Message Peter Eisentraut 2001-11-12 19:24:50 Re: [ODBC] MD5 support for ODBC