Re: "ADD" notice in CREATE/ALTER TABLE

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Philip Warner <pjw(at)rhyme(dot)com(dot)au>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: "ADD" notice in CREATE/ALTER TABLE
Date: 2001-11-04 07:04:10
Message-ID: 200111040704.fA474B602731@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> At 00:40 4/11/01 -0500, Bruce Momjian wrote:
> >Christopher wanted "ADD" used in:
> >
> > ALTER TABLE / ADD PRIMARY-UNIQUE
> > ^^^
> >
> >but not in:
> >
> >
> > CREATE TABLE / PRIMARY-UNIQUE
> >
> >The problem is that the same analyze.c function is used for both cases.
> >I have added code to conditionally use "ADD" only in fhe first case.
> >
>
> What's this in relation to? Shouldn't the syntax be:
>
> ALTER TABLE ADD CONSTRAINT....
>
> Or am I misreading the original message?

Uhh, this was a change if elog(NOTICE) display for Christopher. He
added alter table regression tests. The old message didn't have the
ADD, and I added that. My guess is that we don't spell out the word
CONSTRAINT in the message, just the ALTER and ADD parts.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2001-11-04 10:41:33 Re: compiler warnings in ODBC
Previous Message Philip Warner 2001-11-04 07:00:46 Re: "ADD" notice in CREATE/ALTER TABLE