From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Lee Kindness <lkindness(at)csl(dot)co(dot)uk> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Michael Meskes <meskes(at)postgresql(dot)org> |
Subject: | Re: ecpg - GRANT bug |
Date: | 2001-10-16 13:56:37 |
Message-ID: | 200110161356.f9GDubf12987@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
> Lee Kindness writes:
> > Patch below, it changes:
> > 1. A number of mmerror(ET_ERROR) to mmerror(ET_NOTICE), passing on
> > the (currently) unsupported options to the backend with warning.
> > 2. Standardises warning messages in such cases.
> > 3. Corrects typo in passing of 'CREATE FUNCTION/INOUT' parameter.
>
> And the patch below corrects a pet peeve I have with ecpg, all errors
> and warnings are output with a line number one less than reality...
>
> Lee.
>
> *** ./interfaces/ecpg/preproc/preproc.y.orig Tue Oct 16 10:19:27 2001
> --- ./interfaces/ecpg/preproc/preproc.y Tue Oct 16 10:19:49 2001
> ***************
> *** 36,49 ****
> switch(type)
> {
> case ET_NOTICE:
> ! fprintf(stderr, "%s:%d: WARNING: %s\n", input_filename, yylineno, error);
> break;
> case ET_ERROR:
> ! fprintf(stderr, "%s:%d: ERROR: %s\n", input_filename, yylineno, error);
> ret_value = PARSE_ERROR;
> break;
> case ET_FATAL:
> ! fprintf(stderr, "%s:%d: ERROR: %s\n", input_filename, yylineno, error);
> exit(PARSE_ERROR);
> }
> }
> --- 36,52 ----
> switch(type)
> {
> case ET_NOTICE:
> ! fprintf(stderr, "%s:%d: WARNING: %s\n", input_filename,
> ! yylineno + 1, error);
> break;
> case ET_ERROR:
> ! fprintf(stderr, "%s:%d: ERROR: %s\n", input_filename,
> ! yylineno + 1, error);
> ret_value = PARSE_ERROR;
> break;
> case ET_FATAL:
> ! fprintf(stderr, "%s:%d: ERROR: %s\n", input_filename,
> ! yylineno + 1, error);
> exit(PARSE_ERROR);
> }
> }
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-10-16 13:57:59 | Re: Bug #478: Integer overflow in pg_dump |
Previous Message | Bruce Momjian | 2001-10-16 13:56:31 | Re: ecpg - GRANT bug |
From | Date | Subject | |
---|---|---|---|
Next Message | Vince Vielhaber | 2001-10-16 14:00:11 | Re: Snaptshot appears fine to me ... |
Previous Message | Bruce Momjian | 2001-10-16 13:56:31 | Re: ecpg - GRANT bug |