Bug #478: Integer overflow in pg_dump

Premysl Maly (premek(dot)maly(at)seznam(dot)cz) reports a bug with a severity of 2
The lower the number the more severe it is.

Short Description
Integer overflow in pg_dump

Long Description
Talking about version pg_dump (7.1.3)

Well, it fails, when dumping databases indices (while dumping comment on indexes). I hacked the source code and found the select which failed. It is on line 3036 of file pg_dump.

The select looks like:

SELECT description FROM pg_description where oid = 4294958683

it fails always with dtoi4: Integer out of range

I hacked a source, so now the searched oid is qouted:

SELECT description FROM pg_description where oid = '4294958683'

and the bug is gone. Please in a new release look at that. Large numbers should be qouted otherwise they kill SELECT query.

See you

Premek

Sample Code

in pg_dump source on lines 3036-7 should be:

appendPQExpBuffer(query, "SELECT description FROM pg_description where oid = '");
appendPQExpBuffer(query,oid); appendPQExpBuffer(query,"'");

instead of

appendPQExpBuffer(query, "SELECT description FROM pg_description where oid = ");
appendPQExpBuffer(query,oid);

No file was uploaded with this report