From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Liam Stewart <liams(at)redhat(dot)com> |
Cc: | pgsql-jdbc(at)postgresql(dot)org |
Subject: | Re: driver source code indentation |
Date: | 2001-09-07 21:25:19 |
Message-ID: | 200109072125.f87LPJo28890@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
>
> On Tue, Sep 04, 2001 at 03:25:33PM -0400, Bruce Momjian wrote:
> > I must say it looks very good.
> >
> > Can people tak a look at that and see if they like it? I will work on
> > astyle to find a format that matches the main code indenting.
>
> I like it. The following results in a closer match to the main
> PostgreSQL code:
>
> $ astyle --style=java -b -p -j foo.java
>
> I'm in agreement with Barry about using spaces instead of tabs. astyle
> does that by default (at least with the java style).
OK, I have created pgjindent in src/tools/pgindent, and ran it over the
current CVS. It compiles so it should be fine:
ftp://candle.pha.pa.us/pub/postgresql/astyle_jdbc.tar.gz
I am using the same formatting as the PostgreSQL C code, including tab
size.
I will run this before beta. I will also fix the "if(" to "if (". Any
other issues, please let me know.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-09-07 21:29:30 | Re: Patch for jdbc2 ResultSet.java |
Previous Message | Tom Falconer | 2001-09-07 20:43:26 | Re: DatabaseMetadata problems |