Re: driver source code indentation

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Liam Stewart <liams(at)redhat(dot)com>
Cc: pgsql-jdbc(at)postgresql(dot)org
Subject: Re: driver source code indentation
Date: 2001-09-04 19:25:33
Message-ID: 200109041925.f84JPX527305@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

>
> I suggest that the JDBC driver adopt PostgreSQL's indentation standards
> (see PostgreSQL developers FAQ, question 1). I see that some source
> files have used this standard, but the vast majority do not. We should
> have a standard for consistency and our own sanity if nothing else.

Glad someone brought this up. A while ago I wrote:

I tried pgindent but it doesn't understand Java and made a mess of it.
I used astyle with the options:

$ astyle --style=java -j *.java

I have the reformatted jdbc files at:

ftp://candle.pha.pa.us/pub/postgresql/astyle_jdbc.tar.gz

I must say it looks very good.

Can people tak a look at that and see if they like it? I will work on
astyle to find a format that matches the main code indenting.

If you like it, I will indent just after we go beta.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message T.R.Missner 2001-09-04 19:35:26 Re: error - NOTICE: current transaction...MORE DETAIL...
Previous Message chris markiewicz 2001-09-04 18:33:09 Re: error - NOTICE: current transaction...MORE DETAIL...