Re: [PATCHES] to_char and Roman Numeral (RN) bug

From: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
To: "Command Prompt, Inc(dot)" <pgsql-hackers(at)commandprompt(dot)com>
Cc: Hackers List <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: [PATCHES] to_char and Roman Numeral (RN) bug
Date: 2001-09-04 13:42:02
Message-ID: 20010904154202.G24060@zf.jcu.cz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Fri, Aug 31, 2001 at 07:28:50PM -0700, Command Prompt, Inc. wrote:

> In documenting the to_char() function for transformation of numbers to
> text, I noticed that the "RN" template character sequence was displaying
> some unusual behavior; specifically, unless in fill mode (with the "FM"
> sequence), it would either return the result of the last query executed
> derived from a to_char() result, or what appears to be a garbage pointer
> if there was no such last query.

You are right it's bug. For the 'RM' in non-fillmode is to_char() quiet.
I will fix it for 7.2.

> I consider myself a competent programmer, but never having hacked on
> Postgres, I'm not 100% sure that this modification is totally correct

I check it and if it's good solution we use it.

Thanks!

Karel

PS. Bruce, please, can you apply my previous (31 Aug) patch with to_char()
stuff? I want fix this bug in really actual CVS code. Thanks.

--
Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
http://home.zf.jcu.cz/~zakkr/

C, PostgreSQL, PHP, WWW, http://docs.linux.cz, http://mape.jcu.cz

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-09-04 13:50:49 Re: Bytea/Base64 encoders for libpq - interested?
Previous Message Alexander Troppmann 2001-09-04 13:16:45 Troubles using German Umlauts with JDBC

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2001-09-04 13:50:49 Re: Bytea/Base64 encoders for libpq - interested?
Previous Message Reinhard Max 2001-09-04 12:08:05 Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal